Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search input focus in ayu theme #74505

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Conversation

Cldfire
Copy link
Contributor

@Cldfire Cldfire commented Jul 19, 2020

Closes #74496.

Before:

image

After:

image

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2020
@Cldfire
Copy link
Contributor Author

Cldfire commented Jul 19, 2020

r? @GuillaumeGomez

@MajorBreakfast
Copy link
Contributor

Tiny nit: The border radius on the right seems a bit smaller than the one one the left 😁

@Cldfire
Copy link
Contributor Author

Cldfire commented Jul 19, 2020

Tiny nit: The border radius on the right seems a bit smaller than the one one the left grin

True! This is the same as what the other themes do, though, and oddly enough it doesn't bother me at all, so I'm not interested in changing that here in this PR.

I think it helps differentiate the two types of boxes up there. One is a less important dropdown while the other is for text entry.

@GuillaumeGomez
Copy link
Member

It's voluntary: the left is "joined" with the "all crates" dropdown selector (which has rounded border on the left but not on the right). So please don't change it. :)

margin-left: 8px;
}

#crate-search+.search-input:focus {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this block shouldn't have existed by itself: it's the same selector as above...

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 20, 2020

📌 Commit dec7076 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2020
…arth

Rollup of 13 pull requests

Successful merges:

 - rust-lang#72714 (Fix debug assertion in typeck)
 - rust-lang#73197 (Impl Default for ranges)
 - rust-lang#73323 (wf: check foreign fn decls for well-formedness)
 - rust-lang#74051 (disallow non-static lifetimes in const generics)
 - rust-lang#74376 (test caching opt_const_param_of on disc)
 - rust-lang#74501 (Ayu theme: Use different background color for Run button)
 - rust-lang#74505 (Fix search input focus in ayu theme)
 - rust-lang#74522 (Update sanitizer docs)
 - rust-lang#74546 (Fix duplicate maybe_uninit_extra attribute)
 - rust-lang#74552 (Stabilize TAU constant.)
 - rust-lang#74555 (Improve "important traits" popup display on mobile)
 - rust-lang#74557 (Fix an ICE on an invalid `binding @ ...` in a tuple struct pattern)
 - rust-lang#74561 (update backtrace-rs)

Failed merges:

r? @ghost
@bors bors merged commit 6467f6f into rust-lang:master Jul 21, 2020
@Cldfire Cldfire deleted the fix-search-focus branch March 6, 2021 05:18
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ayu theme search bar focus CSS is broken
7 participants